CL-5848: Fix silent provision parse and canvas deep-link first paint - #32
Merged
TheGreatAxios merged 1 commit intoAug 9, 2026
Merged
Conversation
Reject malformed JSON and schema-invalid provision bodies with 400 instead of treating them as membership probes. Seed canvas state from the path on first paint, drop the unused close helper, and cover path to canvas wiring in pure and SSR tests.
TheGreatAxios
deleted the
cl-5848-post-merge-fix-up-from-retro-review-of-2831
branch
August 9, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retro multi-agent review of landed PRs #28–#31 found three must-fixes. This PR addresses them without reopening those tickets.
closeCanvasColumn; honestopenChannelInCanvas(channelId).data-open="true"for/c/:id, provision 400 cases.Review synthesis (#28–#31)
Critique thrash on first pass; second pass aligned with the must-fixes above. Emil aborted (loop) — no UI critique.
Test plan
bun test packages/onboarding/test/routes.test.ts— 13 passbun test apps/web/src/shell/canvas-column-state.test.ts apps/web/test/routes.test.tsx— passbun run check(local full monorepo check hits pre-existing env issues: postgres role, chat migrations, git backend)Linear: CL-5848