Add ui-test skill: bugs before beauty before drop-dead gorgeous (CL-6650) - #320
Merged
Conversation
Adapts browserbase/skills' ui-test to agent-browser and our own bar (DESIGN.md, consumer language, error-sink refIds), replacing "find any bug" with three ordered tiers that stop at the first one a surface fails. CL-6650
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/skills/ui-test/— a repo skill any lane can invoke to grade a live UI surface through the owner's progression bugs → beauty → drop-dead gorgeous, per CL-6650.browse→ agent-browser as the driver (named sessions,@eNrefs, scoped snapshots), generic UX heuristics → our three CL-6650 tiers (each blocking the next), and "find any bug" → "stop at the first tier failed."snapshot -i -s <selector>..gitignore: added a!.claude/skills/exception (via.claude/*+ re-include) so this repo skill is tracked —.claude/was previously blanket-ignored as local orchestration noise, which conflicted with CL-6650 wanting a committed, lane-invokable skill.Acceptance run (this PR)
Ran the skill by hand against the New Workbench prompt-first screen on
:3000, logged in asquinn.baker@example.com, sessionuitest.CL-6649 seeded-regression follow-up
CL-6649 (invite-agent dialog leaking routines in as agents) has not landed yet (no matching commit or PR on
mainas of this branch). Per the task's guidance, not blocking on it — the seeded-regression acceptance check (temporarily rename Jimmy's row to his description, confirm the skill flags it) is follow-up work once CL-6649 merges.references/regression-seeding.mddocuments exactly how to run that check when it's ready.Test plan
bun run lint— 0 errors (10 pre-existing warnings unrelated to this change):3000's New Workbench prompt-first screen asquinn.baker@example.comviaagent-browser --session uitest; report abovereferences/regression-seeding.mdand confirm the skill flags it