CL-5851: Hide empty pins and page-specific panel bands - #34
Merged
Conversation
Empty chrome is noise. Omit the Pinned band when there are no pins and omit the page-specific band when the route contribution has nothing to render, instead of showing hollow empty-state copy.
TheGreatAxios
commented
Aug 9, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed via dispatch. Tight and correct: hides the Pinned band when pins.length === 0 and the page-specific band when the contribution is null, removing the hollow empty-state copy. Cleans up the now-unused PinIcon and EmptyState imports. Test updated to assert the band is absent when empty. Aligns with AGENTS.md. LGTM — would approve if I could; author/another reviewer can land it. Note the file overlap with CL-5850 (#35) flagged in the PR body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linear
https://linear.app/abklabs/issue/CL-5851
Test plan
bun test ./test/contextual-panel.test.tsxfromapps/webIndependence
Standalone off
main. Touchescontextual-panel.tsxsame file as CL-5850 (Activity rename) — merge either order; small conflict possible on that file only.