CL-5653: Live channel name in the page band - #41
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-5653-channel-context-band
branch
from
August 10, 2026 00:59
6be5e30 to
9968170
Compare
Page-band titles may be React nodes (live channel name), so interpolating them into aria-label is invalid.
TheGreatAxios
force-pushed
the
cl-5653-channel-context-band
branch
from
August 10, 2026 01:04
9968170 to
f75f93b
Compare
The responsive drawer path rendered ContextualPanel without the canvas open handler, which fails typecheck after that prop became required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
titleaccepts aReactNodeso live components can mount without string-only constraints.Closes CL-5653.
Test plan
apps/webunit tests forresolveChannelTitle(loading / empty / known / missing)