CL-5860: responsive shell layout - #45
Merged
Merged
Conversation
Contextual panel becomes an overlay drawer below the narrow breakpoint (<700px) instead of being hidden, the rail collapses to icon-only, and the canvas/column visibility is unchanged. Adds breakpoint predicates (railShowLabels, contextualPanelIsDrawer) with unit tests covering all three modes and the 1280/1024/600 width boundaries. Closes CL-5860
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-5860
Changes
Layout-only responsive behavior for the four-column shell. No IA changes.
Breakpoints (unchanged boundaries, new predicates)
What changed
contextualPanelIsDrawer): below the narrow breakpoint the panel leaves the flex flow entirely and slides in as a fixed overlay from the left, backed by a dimming backdrop that dismisses on click. It never permanently steals width from the main pane. A floating trigger button (PanelLeft icon) appears in the main pane top-left corner.railShowLabels): in narrow mode the rail drops caption labels but keeps every destination — items collapse, not removed. TheshowLabelsprop is threaded throughRail→SidebarRail.overflow: hiddenand flex children usemin-width: 0; the canvas column is gated to expanded-only and the contextual panel is either inline (flex item) or a fixed overlay — neither adds to the document scroll width.Smoke checklist (documented in
breakpoints.ts)Test coverage
New
breakpoints.test.tscovers all three modes for each predicate plus the width-boundary mapping. All 6 tests pass; existing rail tests still pass.