Freeze listDue cursor test clock (CL-7252) - #521
Merged
Merged
Conversation
CL-7252: put() defaulted to Date.now; a tick between rows shuffled expiresAt and flaked CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The listDue cursor test wrote five pending-seed rows with staggered TTLs but used wall-clock Date.now on each put. If the clock ticked between puts, expiresAt order was not user_4 through user_0, which flaked CI on merges with main (including #519).
This freezes now: () => clock on every put and listDue in that test (same pattern as the expired-row test). Production listDue is unchanged.
Linear: CL-7252
Test plan: bun test packages/onboarding/src/pending-seed.test.ts passed three times locally. Do not merge until CI is green.