Re-pin vendored Interchange to the workflow.json retirement - #59
Closed
TheGreatAxios wants to merge 3 commits into
Closed
Re-pin vendored Interchange to the workflow.json retirement#59TheGreatAxios wants to merge 3 commits into
TheGreatAxios wants to merge 3 commits into
Conversation
Upstream's 45 commits since 59f5e7b9 retire the on-disk workflow.json: a deployed workflow's definition is evaluated from its own source closure and re-verified in-child against the approved wire hash, source-ref becomes the only deploy lineage, childWorkflow becomes an owned inline import resolved in memory, and run grants derive from a persisted grant-walk snapshot. Re-applies every workbench-local delta on the new trees, none of which upstream subsumed: the inference.usage forward, the terminal-anchor ownsWorkflowRunRepo gate, the hasConversationText mail drop, and the hub-api needs-you approval route carve-out. Their tests stay green. apps/sidecar keeps its old row: the execution host has not been converted off the retired lineage yet.
Upstream deleted the live-config wrap (wrapHarnessAsSingleStepWorkflow) along with the rest of the live-authored deploy chain. The wrap was a thin adapter over buildSingleStepAgentDefinition, which survives, so the launch now passes the resolved fields directly: the folded run's id, its system prompt, and its catalog-resolved inference preferences. Tools stay empty here — a folded launch pins its tools as packages, not factories.
Records the CL-6324 pin delta, the deltas that survived it, and why the app-side conversion is one migration rather than a per-tree bump: workbench has no code-sourced deploy front, and the retired live-authored chain is what every folded run launches through.
TheGreatAxios
force-pushed
the
cl-6324-repin-interchange
branch
from
August 20, 2026 02:08
b91393a to
74a0d39
Compare
3 tasks
TheGreatAxios
added a commit
that referenced
this pull request
Aug 20, 2026
Extends the vendor/intx/workflow ledger entries for CL-6326: VENDORED.md's local-modifications prose, the package's own VENDORED-FROM delta line, the recomputed kill-dates.txt tree hash, and a docs/revendor-inventory.md entry noting the delta re-applies once PR #59's re-pin lands (upstream's 486a6b1b touched run.ts after this pin).
TheGreatAxios
added a commit
that referenced
this pull request
Aug 20, 2026
Extends the vendor/intx/workflow ledger entries for CL-6326: VENDORED.md's local-modifications prose, the package's own VENDORED-FROM delta line, the recomputed kill-dates.txt tree hash, and a docs/revendor-inventory.md entry noting the delta re-applies once PR #59's re-pin lands (upstream's 486a6b1b touched run.ts after this pin).
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-pins the vendored Interchange trees from
59f5e7b9to upstreammaintip
4ed8baf4(45 commits), whose headline change is the retirement of theon-disk
workflow.json. CL-6324.What this lands
vendor/intx/*rows re-copied at4ed8baf4. Nine treesactually changed (
hub-sessions,workflow-host,workflow,workflow-deploy,types,hub-api,db,agent,hub-agent); therest are byte-identical at both commits and were re-pinned so the ledger
records one commit rather than a mix — which also collapses
inference-catalog's separate5d2aa94apin.them, and none of the five files they touch changed upstream across the 45
commits, so all four re-applied without conflict: the
inference.usageforward, the terminal-anchor
ownsWorkflowRunRepogate, thehasConversationTextmail drop, and theneeds-youapproval-routecarve-out. Their tests pass (11 tests, 3 files).
VENDORED.md, eachVENDORED-FROM, and the kill-date tree hashesupdated together;
check:killdatesis green.agent through
buildSingleStepAgentDefinitiondirectly, now that thewrapHarnessAsSingleStepWorkflowadapter over it is gone.What this does NOT land, and why
The app-side conversion is not here. Upstream retired the live-authored and
instance deploy chains outright —
deploySingleStepAtHead,deployInstanceAtHead,createWorkflowDeployOrchestrator, the deployframe's
definitionfield, and the deploy-ref child spawners. Source-ref isthe only deploy lineage left: a definition is evaluated from the
deployment's own source closure and re-verified in-child.
Workbench has no code-sourced deploy front. Every run it launches goes
through
packages/folded-runs'deployAtHead, which synthesizes asingle-step definition in memory and hands it to the deleted
deploySingleStepAtHead. The replacement takes a registryname@rangepinor an asset tarball and resolves a closure from it, so converting means
giving a folded run a real source package — a migration in its own right,
well past this change's box.
The trees are not separable along that line:
hub-sessions(deployfront),
workflow-deploy(orchestrator),types(deploy frame),workflow-host(child definition load),db(frozen approval bundle,migrations 0082/0083) and
hub-api(run trigger) move together, andapps/sidecarreads the frame both sides write. Leaving any one on the oldpin splits the frame contract down the middle. So the branch re-pins all of
them and carries the conversion as known, mapped work.
apps/sidecar's ledger row deliberately stays at59f5e7b9: the fork hasnot been reconciled with upstream's own conversion of the same files.
docs/revendor-inventory.mdcarries the full map — the four open conversionsites, and the upstream files that are the reference implementation for each.
State of the build
Red, expected, on two counts:
folded-runs(
deploySingleStepAtHead),apps/sidecar(
createWorkflowSpawnChild/createWorkflowSpawnSuspendableChild,projection.definition,SpawnTimeEnv.referencedDefinitionHashes,RunWorkflowChildBindings.workflowDefinitionRepoId), and the packagesthat typecheck through
folded-runs. Every failure is one of thosecontract changes; none is incidental.
cl-5879-shell-mock-v2, not post-mergemain,and needs a rebase once PR CL-5879: Shell Mock v2 — two-column workbench product surfaces #52 lands.
Lint and formatting are clean, and the vendored delta tests pass.
Draft until the deploy-front conversion has an owner and a plan.