Prune stale Rd when last topic removed; refresh stale README#28
Merged
Conversation
document() returned early on the no-blocks path before pruning, so deleting the final documented topic left its Rd behind (codex review). Prune on that path too (every tinyrox-owned Rd is stale when nothing is generated). Also drop the README's references to the removed check_description_cran()/fix_description_cran() and correct the unknown-tag behaviour (warn-and-skip, not fail-fast).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two findings from a review (codex) on the 0.4.0 candidate:
document()returned early on the no-blocks path before pruning, so deleting the final documented topic left itsman/*.Rdbehind. Now it prunes on that path too — when nothing is generated, every tinyrox-owned Rd is stale. Added atest_prune.Rcase (remove the only roxygen → its Rd is pruned).check_description_cran()/fix_description_cran()and the DESCRIPTION-quoting checks, and wrongly said unknown tags "fail fast". Updated to the code/example checks only, and corrected to warn-and-skip.(A third finding —
check_cran()'s result no longer carries$description— is a NEWS note, handled in the 0.4.0 release entry.)212/0 tests;
--as-cranclean. Folds into the 0.4.0 release.