Fix FUNCTIMECTL: convert init_mem from function to task in sim tops#7
Open
velcroapple wants to merge 1 commit into
Open
Fix FUNCTIMECTL: convert init_mem from function to task in sim tops#7velcroapple wants to merge 1 commit into
velcroapple wants to merge 1 commit into
Conversation
Verilator 5.048 correctly enforces IEEE 1800-2023 §13.4: functions cannot invoke tasks (FUNCTIMECTL). init_mem in BlimpV7/V8/Vdemo top-level simulators called fl_mem.init_mem (a task), triggering a hard error. Converted init_mem to a task and updated the DPI-C export accordingly. Fixes the known issue in docs/overview/todo.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verilator 5.048 enforces IEEE 1800-2023 13.4: functions cannot invoke tasks
(FUNCTIMECTL).
init_mem, written as a function in BlimpV7/V8/Vdemo top-levelsimulators, called
fl_mem.init_mem(a task), triggering a hard error.Converted
init_memto a task and updated the DPI-C export accordingly.Full test suite passes (
make check).Fixes the "Functions vs. Tasks" item in docs/overview/todo.rst