Skip to content

RCBC-552: Handle query error code 2120 - #247

Merged
avsej merged 1 commit into
couchbase:mainfrom
DemetrisChr:RCBC-552-query-2120
Sep 8, 2026
Merged

avsej merged 1 commit into
couchbase:mainfrom
DemetrisChr:RCBC-552-query-2120

Conversation

@DemetrisChr

@DemetrisChr DemetrisChr commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Update the C++ core to d08dddc (v1.5.x). The new logic is entirely within the core.
  • Declare the SDK_QUERY_2120 performer cap
  • Update the FIT protocol to the latest

Results

QuerySimulatedErrorCodeTest.handleError2120 FIT test passes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The updated protobuf API introduces ambiguous/unsafe defaults (replica index defaulting) and unclear precedence between new scoring controls that should be clarified to avoid inconsistent behavior across implementations.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the FIT performer protocol (and advertised capabilities) alongside a core bump, with the stated goal of supporting/validating handling for query error code 2120 while keeping the FIT protocol aligned with the latest upstream definitions.

Changes:

  • Adds the SDK_QUERY_2120 capability to the performer and defines new protocol caps/types for updated FIT protocol features.
  • Extends the protocol with KV GetReplica command support types and replica-related exception enums.
  • Extends the Search protocol with scoring configuration options (score fusion controls).
File summaries
File Description
fit-performer/proto/shared.exceptions.proto Adds new replica-related exception type enum values.
fit-performer/proto/sdk.workload.proto Wires a new kv.GetReplica command into the collection-level workload oneof.
fit-performer/proto/sdk.search.proto Adds search scoring messages and new SearchOptions fields to control scoring behavior.
fit-performer/proto/sdk.kv.replicas.proto Introduces replica strategy/index protocol messages for GetReplica.
fit-performer/proto/sdk.kv.options.proto Adds GetReplicaOptions to KV options.
fit-performer/proto/sdk.kv.commands.proto Adds the GetReplica KV command and imports replica strategy types.
fit-performer/proto/sdk.cluster.query.index_manager.proto Removes an unused proto import.
fit-performer/proto/sdk.caps.proto Adds new capability enum values (SDK_SEARCH_SCORE_FUSION, SDK_QUERY_2120, SDK_GET_REPLICA).
fit-performer/lib/fit/performer/service.rb Advertises SDK_QUERY_2120 as supported by the performer.
Review details
  • Files reviewed: 10/10 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread fit-performer/proto/sdk.kv.replicas.proto
Comment thread fit-performer/proto/sdk.search.proto
@avsej
avsej force-pushed the RCBC-552-query-2120 branch from e44f66c to 902df00 Compare September 8, 2026 21:11
@avsej
avsej merged commit a0f2a96 into couchbase:main Sep 8, 2026
35 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants