RCBC-552: Handle query error code 2120 - #247
Merged
Merged
Conversation
DemetrisChr
requested review from
Matt-Woz and
avsej
and
a lite review from Copilot
September 8, 2026 14:40
There was a problem hiding this comment.
🟡 Changes recommended
The updated protobuf API introduces ambiguous/unsafe defaults (replica index defaulting) and unclear precedence between new scoring controls that should be clarified to avoid inconsistent behavior across implementations.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the FIT performer protocol (and advertised capabilities) alongside a core bump, with the stated goal of supporting/validating handling for query error code 2120 while keeping the FIT protocol aligned with the latest upstream definitions.
Changes:
- Adds the
SDK_QUERY_2120capability to the performer and defines new protocol caps/types for updated FIT protocol features. - Extends the protocol with KV
GetReplicacommand support types and replica-related exception enums. - Extends the Search protocol with scoring configuration options (score fusion controls).
File summaries
| File | Description |
|---|---|
| fit-performer/proto/shared.exceptions.proto | Adds new replica-related exception type enum values. |
| fit-performer/proto/sdk.workload.proto | Wires a new kv.GetReplica command into the collection-level workload oneof. |
| fit-performer/proto/sdk.search.proto | Adds search scoring messages and new SearchOptions fields to control scoring behavior. |
| fit-performer/proto/sdk.kv.replicas.proto | Introduces replica strategy/index protocol messages for GetReplica. |
| fit-performer/proto/sdk.kv.options.proto | Adds GetReplicaOptions to KV options. |
| fit-performer/proto/sdk.kv.commands.proto | Adds the GetReplica KV command and imports replica strategy types. |
| fit-performer/proto/sdk.cluster.query.index_manager.proto | Removes an unused proto import. |
| fit-performer/proto/sdk.caps.proto | Adds new capability enum values (SDK_SEARCH_SCORE_FUSION, SDK_QUERY_2120, SDK_GET_REPLICA). |
| fit-performer/lib/fit/performer/service.rb | Advertises SDK_QUERY_2120 as supported by the performer. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
avsej
force-pushed
the
RCBC-552-query-2120
branch
from
September 8, 2026 21:11
e44f66c to
902df00
Compare
avsej
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
SDK_QUERY_2120performer capResults
QuerySimulatedErrorCodeTest.handleError2120FIT test passes