RCBC-554: Add support for search score fusion - #248
Merged
Merged
Conversation
DemetrisChr
requested review from
avsej
and
a balanced review from Copilot
and removed request for
Copilot
September 8, 2026 16:32
There was a problem hiding this comment.
🟢 Approval recommended
The only unresolved finding is a non-blocking documentation nit.
Pull request overview
Adds search score-fusion support across the Ruby API, native backend, Protostellar layer, and FIT performer.
Changes:
- Adds none, reciprocal-rank, and relative-score scoring modes.
- Validates deprecated
disable_scoringinteractions and transport support. - Updates FIT protocols, capability mapping, performer logic, and tests.
File summaries
| File | Description |
|---|---|
test/search_scoring_test.rb |
Tests scoring modes, validation, and compatibility. |
lib/couchbase/search_options.rb |
Defines scoring strategies. |
lib/couchbase/protostellar/request_generator/search.rb |
Maps supported scoring and rejects unsupported fusion. |
lib/couchbase/options.rb |
Adds scoring options and conflict validation. |
fit-performer/proto/shared.exceptions.proto |
Synchronizes replica exceptions. |
fit-performer/proto/sdk.workload.proto |
Synchronizes replica commands. |
fit-performer/proto/sdk.search.proto |
Adds scoring messages and options. |
fit-performer/proto/sdk.kv.replicas.proto |
Defines replica strategies. |
fit-performer/proto/sdk.kv.options.proto |
Defines replica options. |
fit-performer/proto/sdk.kv.commands.proto |
Defines replica command payloads. |
fit-performer/proto/sdk.cluster.query.index_manager.proto |
Removes an unused import. |
fit-performer/proto/sdk.caps.proto |
Adds score-fusion and replica capabilities. |
fit-performer/proto/.clang-format |
Excludes mirrored schemas from formatting. |
fit-performer/lib/fit/performer/service.rb |
Advertises score-fusion support. |
fit-performer/lib/fit/performer/commands/search/search_query_command.rb |
Applies scoring to legacy search queries. |
fit-performer/lib/fit/performer/commands/search/search_command.rb |
Applies scoring to search requests. |
fit-performer/lib/fit/performer/commands/search/options_builder.rb |
Converts FIT scoring options. |
ext/rcb_search.cxx |
Maps scoring into native requests. |
Nit: In lib/couchbase/search_options.rb:1340, use the actual public type name SearchScoringNone instead of ScoringNone in the documentation.
Review details
- Files reviewed: 19/19 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
DemetrisChr
force-pushed
the
score-fusion
branch
from
September 8, 2026 17:06
8b1890a to
2b89e40
Compare
avsej
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As part of SDK API 3.11 support we are adding the new
ScoringAPI which enables configuring score fusion for a hybrid FTS query.Changes
SearchOptions#disable_scoringSearchOptions#scoringwhich can accept three types of scoringCouchbase::SearchScoring::SearchScoringNoneSearchOptions#disable_scoringSearchOptions#disable_scoringis set toTrueCouchbase::SearchScoring::SearchScoringRelativeScoreFusion(Stability uncommitted)Couchbase::SearchScoring::SearchScoringReciprocalRankFusion(Stability uncommitted)FeatureNotAvailableif score fusion is used withcouchbase2Results
Score fusion FIT tests pass