chore: pin json gem to < 3.0 to fix active_support conflict - #252
Merged
Merged
Conversation
avsej
added
the
rubber stamp needed
There was a problem hiding this comment.
🟢 Approval recommended
The focused dependency constraint directly prevents the documented ActiveSupport incompatibility.
Pull request overview
Pins the development JSON dependency to maintain compatibility with ActiveSupport tests.
Changes:
- Restricts
jsonto versions below 3.0.
File summaries
| File | Description |
|---|---|
Gemfile |
Adds the development-only JSON version constraint. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
avsej
force-pushed
the
fix-json-quirks-mode
branch
from
September 9, 2026 16:37
b899520 to
06719a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
ArgumentError: unknown keyword: quirks_modein tests caused byjson3.0.2 removing support forquirks_mode, whichactivesupport-7.0.10still relies on.Pins
jsonto< 3.0in development to prevent this.