fix(docs): correct stale hairpin-proxy uninstall claim and package names - #709
Open
Aleksei Sviridkin (lexfrei) wants to merge 2 commits into
Open
Aleksei Sviridkin (lexfrei) wants to merge 2 commits into
Aleksei Sviridkin (lexfrei) wants to merge 2 commits into
Conversation
The tenant disable troubleshooting list named a manual kubectl delete of the HelmRelease object as a way to bypass helm uninstall and skip the chart's pre-delete hook. helm-controller runs the uninstall step (and the hook with it) for any HelmRelease deletion that is not suspended, so a bare object delete does not skip it. The case that actually skips the hook is a HelmRelease that was already suspended at the moment it got deleted, since the uninstall branch is conditioned on the resource not being suspended. Assisted-by: LLM Signed-off-by: Aleksei Sviridkin <f@lex.la>
The GPU and NFS driver guides told operators to add the bare component name (gpu-operator, nfs-driver) to bundles.enabledPackages. The platform chart's optional-package helper matches enabledPackages entries against the fully-qualified cozystack.<name> form, so the bare examples add a value the chart never checks and enable nothing. Later doc versions already carry the qualified form; this backports the same fix to v1.0 and v1.1. Assisted-by: LLM Signed-off-by: Aleksei Sviridkin <f@lex.la>
✅ Deploy Preview for cozystack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Aleksei Sviridkin (lexfrei)
marked this pull request as ready for review
September 23, 2026 13:47
Aleksei Sviridkin (lexfrei)
requested review from
Andrei Kvapil (kvaps),
Timofei Larkin (lllamnyp),
myasnikovdaniil and
Timur Tukaev (tym83)
as code owners
September 23, 2026 13:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two docs corrections, both checked against source.
The tenant-disable troubleshooting list on the hairpin-proxy-protocol page had the failure case backwards. It named
kubectl delete hras a way to skiphelm uninstalland the chart's pre-delete hook. helm-controller runs the uninstall, and the hook with it, for every deleted HelmRelease that is not suspended. The case that really skips the hook is a HelmRelease that was already suspended when it got deleted. Fixed in next, v1.4, v1.5 and v1.6.The GPU operator and NFS driver guides on v1.0 and v1.1 add the bare name to
bundles.enabledPackages. The platform chart matches that list against the fullcozystack.<name>form, sogpu-operatorornfs-drivermatches nothing and the package is never enabled. v1.2 and later already use the qualified name.