fix: adapt _safe_repair_json to json-repair 0.60 semantics#6613
Merged
theCyberTech merged 1 commit intoJul 22, 2026
Merged
Conversation
json-repair >= 0.60 returns an empty string for plain-text input and
wraps brace-enclosed junk in a single-element list instead of the old
""/{} sentinel values. Treat both as unrepairable so the original
tool input is preserved.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
theCyberTech
merged commit Jul 22, 2026
9543340
into
fix/vulnerability-scan-updates
41 of 47 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #6612 (json-repair 0.60.1 bump).
json-repair 0.60.x changed how it handles non-JSON input:
''(previously'""'/'{}'sentinels){temperature in SF}now repairs to a single-element list["temperature in SF}"]Both cases broke
_safe_repair_json's unrepairable-detection inlib/crewai/src/crewai/agents/parser.py, mangling plain-text tool inputs. This treats empty results and list results (for non-array input) as unrepairable, preserving the original input.Tests
test_crew_agent_parser.py(15 previously failing) andtest_tool_usage.pynow pass.