fix: surface portal token JWT errors instead of masking as NuGet sync failure - #782
Draft
m-s- wants to merge 1 commit into
Draft
fix: surface portal token JWT errors instead of masking as NuGet sync failure#782m-s- wants to merge 1 commit into
m-s- wants to merge 1 commit into
Conversation
… failure cmf login --token with an invalid/opaque PAT or a JWT missing the sub claim previously crashed during NuGet sync at NuGetRepositoryCredentials.cs:141 via new XAttribute(ValueAttr, null) -> ArgumentNullException wrapped as Failed to sync credentials into NuGet config file: /root/.nuget/NuGet/NuGet.Config, hiding the real cause. - PortalRepositoryCredentials.GetDerivedCredentials now catches ParseJwt failures and wraps them as Failed to derive credentials from Portal token ... token is not a valid JWT, and explicitly checks for missing/empty sub claim - NuGetRepositoryCredentials.ValidateCredentials now validates Username/Password (with hint about sub claim) and SyncCredentials validates early to avoid ArgumentNullException - RepositoryAuthStore.Save validates derived credentials before syncing so errors are surfaced directly - add regression tests for missing sub, invalid JWT format and NuGet missing username/password validation/sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmf login --token with an invalid/opaque PAT or a JWT missing the sub claim previously crashed during NuGet sync at
NuGetRepositoryCredentials.cs:141 via new XAttribute(ValueAttr, null) -> ArgumentNullException wrapped as Failed to sync credentials into NuGet config file: /root/.nuget/NuGet/NuGet.Config, hiding the real cause.