fix: preserve primary auth for pooled team accounts#1
Open
blankcarrot wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two account-identity bugs in
codex-poolwhen managing multiple ChatGPT OAuth accounts. First, persisted account rows are now keyed by the OAuth user subject (sub) instead ofChatGPT-Account-Id, which allows multiple users from the same organization/team to coexist in the pool without overwriting each other. The sharedchatgpt_account_idis still stored as metadata for outbound requests and usage lookups.Second, adding a pool account no longer corrupts
~/.local/share/opencode/auth.jsonby replacing the primaryopenaiOAuth entry with the fakeshadowAPI credential. Pool-account auth flows now preserve the mirrored primary OAuth auth state, so new sessions continue to start with valid OpenAI OAuth credentials. Regression tests were added for both behaviors, and the full test suite and typecheck pass.