Frontend/cosm public search restriction column#1571
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR adds licensee eligibility tracking and a restriction column to cosmetology public search lists: a new enum and model field, display and restricted-state helpers, serializer mapping and mocks, updated tests, conditional header/row rendering, translations, styling, and a mutation tweak to preserve fetch-only properties. ChangesLicensee Eligibility Display
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@webroot/src/components/Licensee/LicenseeListLegacy/LicenseeListLegacy.ts`:
- Line 151: Remove the debug console.log in LicenseeListLegacy by deleting the
line that logs `HEADER isPublicSearch: ${this.isPublicSearch}` inside the
LicenseeListLegacy class (where the property isPublicSearch is referenced); if
runtime visibility is required replace it with the existing app logging
mechanism (e.g., processLogger or a debug logger) or remove entirely so no
console.log remains in production code.
- Around line 160-166: The non-legacy headerRecord is missing isPublicSearch:
true causing the header row to hide the eligibility column in public search;
update the object built where headerRecord is created (the ternary that checks
this.isPublicSearch) to include isPublicSearch: true alongside
eligibilityDisplay and isRestricted so LicenseeRow.vue’s (isPublicSearch ||
item.isPublicSearch) check works the same as the legacy implementation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 667b2892-affd-4c2a-93e9-0035b0f44501
📒 Files selected for processing (9)
webroot/src/components/Licensee/LicenseeList/LicenseeList.tswebroot/src/components/Licensee/LicenseeListLegacy/LicenseeListLegacy.tswebroot/src/components/Licensee/LicenseeRow/LicenseeRow.vuewebroot/src/locales/en.jsonwebroot/src/locales/es.jsonwebroot/src/models/Licensee/Licensee.model.spec.tswebroot/src/models/Licensee/Licensee.model.tswebroot/src/network/mocks/mock.data.tswebroot/src/styles.common/_lists.less
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@webroot/src/store/license/license.mutations.ts`:
- Around line 82-87: The merge logic in license.mutations.ts is using inverted
checks for preserving stored-only properties: instead of checking that the
stored record (currentLicenseeRecord) has listFetchOnlyProp and the incoming
licensee is missing it, the code currently checks the opposite; change the
condition to if (Object.hasOwn(currentLicenseeRecord, listFetchOnlyProp) &&
!Object.hasOwn(licensee, listFetchOnlyProp)) and then copy
currentLicenseeRecord[listFetchOnlyProp] onto licensee[listFetchOnlyProp] so
only missing incoming fields are filled from the stored record.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 71877109-de72-40f0-a1a6-108746300c01
📒 Files selected for processing (8)
webroot/src/components/Licensee/LicenseeList/LicenseeList.tswebroot/src/components/Licensee/LicenseeListLegacy/LicenseeListLegacy.tswebroot/src/locales/en.jsonwebroot/src/locales/es.jsonwebroot/src/models/Licensee/Licensee.model.spec.tswebroot/src/models/Licensee/Licensee.model.tswebroot/src/network/mocks/mock.data.tswebroot/src/store/license/license.mutations.ts
💤 Files with no reviewable changes (1)
- webroot/src/components/Licensee/LicenseeListLegacy/LicenseeListLegacy.ts
✅ Files skipped from review due to trivial changes (1)
- webroot/src/locales/es.json
jsandoval81
changed the title
|
@jlkravitz This is ready for your review. |
jlkravitz
left a comment
jlkravitz
left a comment
There was a problem hiding this comment.
Couple small comments!
|
@jlkravitz This is ready for re-review. |
jlkravitz
left a comment
jlkravitz
left a comment
There was a problem hiding this comment.
@isabeleliassen This is good to merge!
3 participants
Requirements List
Description List
Testing List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsCloses #1479
Summary by CodeRabbit
New Features
Style
Tests
Chores