reclaimspace: Add UNIMPLEMENTED error code to prevent retrying#81
Merged
mergify[bot] merged 1 commit intoJun 30, 2026
Merged
Conversation
The filesystem may not support fstrim, or the block-device may lack support for DISCARD operations. In these cases there is no need to retry unless there was an update of some component that could add support for space reclaiming. Signed-off-by: Niels de Vos <ndevos@ibm.com>
Madhu-1
approved these changes
Jun 30, 2026
black-dragon74
approved these changes
Jun 30, 2026
|
Queued — the merge queue status continues in this comment ↓. |
Merge Queue Status
This pull request spent 2 minutes 41 seconds in the queue, including 2 minutes 22 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filesystem may not support fstrim, or the block-device may lack
support for DISCARD operations. In these cases there is no need to retry
unless there was an update of some component that could add support for
space reclaiming.
The Unimplemented error code is already detected by the controller:
ControllerReclaimSpace
https://github.com/csi-addons/kubernetes-csi-addons/blob/93075184b184af4b635602461c714085c19c7e14/internal/controller/csiaddons/reclaimspacejob_controller.go#L435-L443
NodeReclaimSpace
https://github.com/csi-addons/kubernetes-csi-addons/blob/93075184b184af4b635602461c714085c19c7e14/internal/controller/csiaddons/reclaimspacejob_controller.go#L474-L482