replication: replace deprecated volume_id with reserved field#86
Open
santhoshatdell wants to merge 1 commit into
Open
replication: replace deprecated volume_id with reserved field#86santhoshatdell wants to merge 1 commit into
santhoshatdell wants to merge 1 commit into
Conversation
The volume_id field (field number 1) in all replication request messages was deprecated in favor of replication_source. Replace the deprecated field declaration with `reserved 1` to fully remove it from the generated Go code. This prevents validation middleware (e.g. gocsi spec validator) from rejecting replication RPCs due to an empty volume_id field, which is the expected state when using the newer replication_source field. Fixes: csi-addons#85 Signed-off-by: Santhosh Lakshmanan <Santhosh.Lakshmanan@dell.com>
santhoshatdell
force-pushed
the
pvt/volume-id-reserved
branch
from
69ac7aa to
e0eb841
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The volume_id field (field number 1) in all replication request messages was deprecated in favor of replication_source. Replace the deprecated field declaration with
reserved 1to fully remove it from the generated Go code.This prevents validation middleware (e.g. gocsi spec validator) from rejecting replication RPCs due to an empty volume_id field, which is the expected state when using the newer replication_source field.
Fixes: #85