Conversation
Use the upstream core language interface, keep rate styling and synopsis rendering in the IDE, and adapt syntax trees to plain evaluation ranges. Gate deployment on the upstream 1.0.3 release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the IDE to
@kunstmusik/codemirror-lang-csoundand keep application behavior in the IDE.csound({ mode })interface, not/compat.{ from, to, kind }values from the IDE's context helper.This branch starts from local
developand also includes its existingchore(deps): update CodeMirror and Csound browsercommit.Release gate
Depends on kunstmusik/codemirror-lang-csound#1.
Keep this PR in draft until upstream releases 1.0.3 or later. The manifest and lockfile require 1.0.3, which was not published when this branch was tested. The new lock entry has no registry URL or integrity hash yet; no preview archive or made-up release hash is committed.
After the release:
npm ciand repeat the checks below against that release.Validation
Tested against a locally packed upstream 1.0.3 build:
Normal registry installation remains blocked until upstream publishes the required version.
Checked syntax adapters
The IDE now imports generated names and grammar-owned identifier groups from the upstream package's
/syntaxentry. Its highlighter no longer copies the identifier-node list. Synopsis and context-selection code use checked node constants, and keyword-node sets validate their entries at compile time.Upstream adds negative type tests and CI checks for stale generated artifacts. All 30 IDE tests, typecheck, lint, formatting checks for changed files, and the production build pass against the updated local 1.0.3 preview. The release gate above still applies.