Skip to content

ENH: control amplitude envelope of the coupled waveform#87

Merged
ctrltz merged 12 commits into
masterfrom
ctrltz/83-amplitude-envelope
Jul 22, 2025
Merged

ENH: control amplitude envelope of the coupled waveform#87
ctrltz merged 12 commits into
masterfrom
ctrltz/83-amplitude-envelope

Conversation

@ctrltz

@ctrltz ctrltz commented Jun 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner

This PR:

  • introduces control over amplitude envelope for Hilbert-based coupling functions (for now, using either the envelope of input waveform or the envelope of a randomly generated waveform)
  • fixes tests for the von Mises coupling function - adds a fixed random state for stability, set both lower and upper bound for the expected coupling value. Close Tests for the von Mises coupling are unstable #32

And fixed the bug, the results of select_kappa example seem fine again:
kappa-to-plv_length60sec

@ctrltz ctrltz mentioned this pull request Jun 27, 2025
Open
3 tasks
@ctrltz
ctrltz requested a review from astudenova June 27, 2025 13:18
astudenova
astudenova approved these changes Jun 30, 2025
View reviewed changes

@astudenova astudenova left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work well. ദ്ദി

Comment thread src/meegsim/coupling.py
@ctrltz
ctrltz merged commit 0b5f210 into master Jul 22, 2025
6 of 7 checks passed
@ctrltz
ctrltz deleted the ctrltz/83-amplitude-envelope branch July 22, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astudenova astudenova astudenova approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests for the von Mises coupling are unstable

2 participants

@ctrltz @astudenova