Failure to build pa because of missing source file for ninja

[nightduck]

System

Ubuntu 22.04

Error

...
ninja: Entering directory `out/Default'
ninja: error: '../../third_party/libc++/src/src/algorithm.cpp', needed by 'obj/buildtools/third_party/libc++/libc++/algorithm.o', missing and no known rule to make it

Steps to reproduce

git clone git@github.com:daanx/mimalloc-bench.git
cd mimalloc-bench
./build-bench-env.sh all

This bug occurs on this line in the build script

mimalloc-bench/build-bench-env.sh

Line 528 in a45c31e

autoninja -C out/Default

The setup_packages function ran correctly and ninja-build did get installed

[nightduck]

Commenting out setup_pa yields an error in setup_tcg, because gawk is not installed

mimalloc-bench/build-bench-env.sh

Line 581 in a45c31e

gawk -i inplace '(f && g) {$0="linkshared = True, )"; f=0; g=0} /This library provides tcmalloc always/{f=1} /alwayslink/{g=1} 1' tcmalloc/BUILD

[nightduck]

After adding gawk to the list of apt-get install packages, everything else builds correctly

mimalloc-bench/build-bench-env.sh

Lines 417 to 420 in a45c31e

	aptinstall "g++ clang lld llvm-dev unzip dos2unix linuxinfo bc libgmp-dev wget \
	cmake python3 ruby ninja-build libtool autoconf sed ghostscript time \
	curl automake libatomic1 libgflags-dev libsnappy-dev zlib1g-dev libbz2-dev \
	liblz4-dev libzstd-dev libreadline-dev"

[jvoisin]

Can you please send a pull-request fixing this? <3

[nightduck]

I can submit a PR with the gawk fix, but I don't know how to fix the autoninja line failing

[luzhixing12345]

the same issue for me, use no-pa in args flags to skip building pa for now

[caizixian]

This was caused by https://github.com/1c3t3a/partition_alloc_builder not pinning the upstream commits, and getting out of sync after this commit chromium/chromium@35902f7