Skip to content

Fix | Preserve namespaces for unknown custom resources - #482

Open
dag-andersen wants to merge 1 commit into
mainfrom
fix/477-preserve-unknown-resource-namespaces
Open

Fix | Preserve namespaces for unknown custom resources#482
dag-andersen wants to merge 1 commit into
mainfrom
fix/477-preserve-unknown-resource-namespaces

Conversation

@dag-andersen

Copy link
Copy Markdown
Owner

Summary

  • track known cluster-scoped resource kinds instead of known namespaced kinds
  • default undiscovered custom resource kinds to namespaced during Argo CD normalization
  • preserve same-named custom resources that live in different namespaces
  • apply the behavior to server API, repo-server API, and app-of-apps rendering

Testing

  • go test ./pkg/extract -run 'TestNormalizeNamespaces|TestResourceInfoProvider' -count=1
  • go test ./pkg/reposerverextract -run '^$'

Closes #477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug | Custom resources lose their namespace when the CRD isn't installed in the preview cluster, silently dropping same-named resources

1 participant