Clamp EMS/GVS/ET params in /execute to the bounds manual_control_app.py already enforces#3
Open
DIYA73 wants to merge 1 commit into
Open
Clamp EMS/GVS/ET params in /execute to the bounds manual_control_app.py already enforces#3DIYA73 wants to merge 1 commit into
DIYA73 wants to merge 1 commit into
Conversation
…py already enforces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/execute accepted amplitude/frequency/duration/pulse_width straight off the POST body with no bounds-checking, even though manual_control_app.py already hardcodes safe ranges for these same parameters on its sliders (amplitude 0-60, pulse width 0-1000μs, frequency 0-100Hz, duration 0-10000ms). This applies those same bounds to /execute so an out-of-range payload can't drive the stimulator past them — values outside range are clamped and logged, not silently dropped.