Avoid ambiguities#63
Open
sharwell wants to merge 3 commits intodaniellansun:masterfrom
Open
Conversation
sharwell
commented
Jan 31, 2020
Comment on lines
+258
to
+266
| : LBRACE | ||
| ( | ||
| /* Only enum can have enum constants */ | ||
| { 2 == $t }? | ||
| enumConstants? sep? | ||
| nls enumConstants | ||
| | | ||
|
|
||
| ) | ||
| classBodyDeclaration[$t]? (sep classBodyDeclaration[$t])* sep? RBRACE | ||
| sep? | ||
| (classBodyDeclaration[$t] (sep classBodyDeclaration[$t])*)? sep? RBRACE |
Contributor
Author
There was a problem hiding this comment.
📝 This change falls out from the following in the original rule:
classBodyDeclaration[$t]? (sep classBodyDeclaration[$t])*
While it was perhaps not intentional, one interpretation of this is:
(sep classBodyDeclaration[$t])+
Which means sep can appear before the first classBodyDeclaration for enum types or any other type. This allowed me to extract the sep? from the enum-specific alternative, and leverage that for the nls following LBRACE in non-enum types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses some specific ambiguities I observed.