Skip to content

fix(pulse): fmtHero renders negative amounts as unabridged digits #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
takanorinishida wants to merge 1 commit into from
Closed

fix(pulse): fmtHero renders negative amounts as unabridged digits #1778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions LifeOS/install/LIFEOS/PULSE/Observability/src/app/finances/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,13 +185,20 @@ interface FinancesDataV2 {

function fmtHero(dollars: number | null | undefined): string {
const n = Number(dollars) || 0;
if (n >= 1_000_000) return `$${(n / 1_000_000).toFixed(1)}M`;
if (n >= 10_000) return `$${Math.round(n / 1000)}K`;
if (n >= 1_000) {
const k = n / 1000;
return k % 1 === 0 ? `$${k.toFixed(0)}K` : `$${k.toFixed(1)}K`;
// Threshold on magnitude, not the signed value — a negative net (a real,
// common case: this card renders red ink when spending exceeds income)
// otherwise misses every `>=` check above and falls through to the last
// branch's unabridged digit string (e.g. "$-2,120,000" next to a sibling
// KPI reading "$2.1M").
const sign = n < 0 ? "-" : "";
const abs = Math.abs(n);
if (abs >= 1_000_000) return `${sign}$${(abs / 1_000_000).toFixed(1)}M`;
if (abs >= 10_000) return `${sign}$${Math.round(abs / 1000)}K`;
if (abs >= 1_000) {
const k = abs / 1000;
return k % 1 === 0 ? `${sign}$${k.toFixed(0)}K` : `${sign}$${k.toFixed(1)}K`;
}
return `$${Math.round(n).toLocaleString()}`;
return `${sign}$${Math.round(abs).toLocaleString()}`;
}

function fmtExact(dollars: number | null | undefined): string {
Expand Down