Add inline pull request review threads#49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
GitHub review comments are stored in the review-thread connection rather than the issue-comment collection Strand previously loaded. Comments created successfully on GitHub therefore disappeared from Strand after refresh and could not be navigated from Conversation back to their code.
Impact
Review comments now remain visible inside Strand, replies stay grouped at their code location, and reviewers can jump directly from Conversation to the corresponding file and inline thread.
Validation
pnpm --filter ./ui test— 217 tests passedpnpm --filter ./ui exec tsc --noEmitcargo test -p strand-tauri --bin strand pull_requests— 9 tests passedcargo check -p strand-core -p strand-taurigit diff --check