ResourceItem, EpubDoc::get_cover_id, EpubDoc::get_nav_id, EpubDoc::get_title#54
Merged
danigm merged 3 commits intodanigm:masterfrom May 27, 2025
Merged
ResourceItem, EpubDoc::get_cover_id, EpubDoc::get_nav_id, EpubDoc::get_title#54danigm merged 3 commits intodanigm:masterfrom
danigm merged 3 commits intodanigm:masterfrom
Conversation
Field `cover_id` is removed from `EpubDoc`. The value can be found by the existing method `get_cover_id` (implementation modified). A similar method `get_nav_id` is added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three commits are
ResourceItemto replace tuple and stores (manifest) item properties. This enables the next point.get_cover_idand addedget_nav_id. Looking for the cover's ID in the method instead of when initializing (and storing in a field) is kind of a conversion to a lazy approach. It doesn't matter much but my real motivation was to delete this side-effect of settingself.cover_idfrom the metadata construction procedure.metadata's type makes getting the title (into a string) need more typing. Considering that is perhaps a very common task,get_titleis provided conveniently.