Fix naming convention from pages to chapters#58
Merged
danigm merged 2 commits intodanigm:masterfrom Oct 28, 2025
Merged
Conversation
Owner
That's true, but this change will break the API completely. Can you add the previous public functions as a wrapper for compatibility? Maybe we can add some kind of deprecation message so we can keep the old API working for some time before actually dropping. |
Author
|
good idea, will work on it later |
danigm
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since epubs are divided into chapters, I think the naming convention for *_pages() is wrong.
Pages are a construct based on client sided parameters, such as text size, font, display size etc. and will vary between parameters.
Other than that great lib!!