use ncx file path as base path for toc#60
Merged
danigm merged 2 commits intodanigm:masterfrom Jan 23, 2026
Merged
Conversation
danigm
requested changes
Jan 22, 2026
danigm
approved these changes
Jan 23, 2026
Owner
danigm
left a comment
danigm
left a comment
There was a problem hiding this comment.
Now looks better, we can merge it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when filling the TOC, this crate uses the EPUB's base path (derived from the OPF's path) to determine the paths of items in the TOC. This works fine when the NCX file is in the same directory as the OPF; but it leads to incorrect TOC-paths when the NCX is in a different directory than the OPF. For example, this IDPF sample EPUB has its NCX in a subfolder relative to the OPF, and accordingly this crate misparses its sole TOC-item's path as
EPUB/../Content/pageNum-9.svgwhen it should properly beEPUB/Navigation/../Content/pageNum-9.svg.This PR, then, is a fix for that misparsing. It updates the crate to fill TOC items' paths based on the NCX's base path, rather than the OPF's.
(Even more ideally, we might want to factor out
..-like elements and have it parse asEPUB/Content/pageNum-9.svg. But that's currently harder to implement, sincePath::normalize_lexicallyhasn't yet made it out of nightly; thus I restrained this PR to just the more basic fix.)