Skip to content

fixed #10610 - added support for PCRE2#8382

Draft
firewave wants to merge 2 commits intodanmar:mainfrom
firewave:regex-pcre2-x
Draft

fixed #10610 - added support for PCRE2#8382
firewave wants to merge 2 commits intodanmar:mainfrom
firewave:regex-pcre2-x

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

@firewave firewave commented Mar 26, 2026

No description provided.

@firewave firewave mentioned this pull request Mar 26, 2026
Merged
@firewave firewave changed the title added support for PCRE2 / added engine to rule XML to specify regex engine fixed #10610 - added support for PCRE2 Mar 27, 2026
Harvester57
Harvester57 reviewed Apr 3, 2026
View reviewed changes
cmake/findDependencies.cmake Outdated
@@ -32,7 +32,13 @@ if(HAVE_RULES)
find_path(PCRE_INCLUDE pcre.h)
Copy link
Copy Markdown

@Harvester57 Harvester57 Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need pcre.h if you are using pcre2.h ? I'm trying to build with CMake on Debian Trixie, for which libpcre3-dev is not available, and the build still fails because CMake cannot detect pcre.h

Copy link
Copy Markdown
Collaborator Author

@firewave firewave Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need pcre.h if you are using pcre2.h ?

No.

This is still WIP. I have not added build options separating PCRE from PCRE2 yet.

@firewave firewave mentioned this pull request Apr 6, 2026
Draft
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 7, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Harvester57
Copy link
Copy Markdown

Harvester57 commented Apr 7, 2026

Looking almost good with cmake -S . -B build -DCMAKE_BUILD_TYPE=Release -DHAVE_RULES=ON -DUSE_PCRE2=ON -DDISABLE_PCRE1=ON : https://github.com/Harvester57/docker-cppcheck/actions/runs/24076359858/job/70225683963 👍

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Apr 7, 2026

almost good

Hence it still being a draft. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Harvester57 Harvester57 Harvester57 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@firewave @Harvester57