Fix #14632 FN funcArgNamesDifferent when argument is unnamed#8399
Fix #14632 FN funcArgNamesDifferent when argument is unnamed#8399chrchr-github wants to merge 12 commits intodanmar:mainfrom
Conversation
| naming-privateMemberVariable:externals/tinyxml2/tinyxml2.h | ||
| functionStatic:externals/tinyxml2/tinyxml2.cpp | ||
| funcArgNamesDifferent:externals/tinyxml2/tinyxml2.cpp | ||
| funcArgNamesDifferent:externals/tinyxml2/tinyxml2.h |
There was a problem hiding this comment.
how about ignoring such warnings in all externals funcArgNamesDifferent:externals/**
There was a problem hiding this comment.
We should keep granular warnings - since we control when this code is updated I would argue we should be even using more granular suppressions with lines so to properly differentiate them as this might suppress/obfuscate fixes/regressions.
There are also also mainly true positives and need to be fixed upstream. Unfortunately landing fixes has not been that successful in the past. I will take another try in the future.
| void resizeEvent(QResizeEvent *event) override; | ||
|
|
||
| private slots: | ||
| void updateLineNumberAreaWidth(int newBlockCount); |
There was a problem hiding this comment.
Providing the argument name in the declaration looks like good proper clean code to me. Even if argument name is empty in definition.
It's not a likely "mistake" imho.
There was a problem hiding this comment.
It is still provided in a comment. Having the information that the parameter is unused in a header file also informs the user of e.g. a library.
There was a problem hiding this comment.
I am feeling that this might be too pedantic for some developers and tweaking the id would make sense.
There was a problem hiding this comment.
"some developers" that includes us I don't see it as a mistake that we wrote the code in this way.
|
4 participants
No description provided.