Update calculator.test.js with describe.skip to describe#2465
Update calculator.test.js with describe.skip to describe#2465nikhilp2p wants to merge 1 commit intodanthareja:nikhilp2pfrom
Conversation
Thank you for the submission, @nikhilp2p! I'll review your code shortly, hang tight. |
dantharejabot
left a comment
There was a problem hiding this comment.
This is a great attempt, @nikhilp2p!
I would like to request a few changes before merging your work. Please review my comments below and make the appropriate changes to your code.
After you update your code locally, follow the instructions to save your changes locally and push your changes to your fork.
When you push your changes to your fork, I'll come back for another review.
Your code style completely follows the style guide. Nice job!
There are 5 tests failing. Please revisit your code and make the failing tests pass.
❌ _check should throw a TypeError if arguments are not numbers
-actual
+expected
-
+function TypeError() { [native code] }AssertionError: expected [Function] to throw TypeError
at Context.<anonymous> (src/calculator.test.js:14:54)
at processImmediate (node:internal/timers:464:21)
❌ _check should be called once in "add"
AssertionError: expected _check to have been called exactly once, but it was called 0 times
at Context.<anonymous> (src/calculator.test.js:24:43)
at processImmediate (node:internal/timers:464:21)
❌ _check should be called once in "subtract"
AssertionError: expected _check to have been called exactly once, but it was called 0 times
at Context.<anonymous> (src/calculator.test.js:30:43)
at processImmediate (node:internal/timers:464:21)
❌ _check should be called once in "multiply"
AssertionError: expected _check to have been called exactly once, but it was called 0 times
at Context.<anonymous> (src/calculator.test.js:36:43)
at processImmediate (node:internal/timers:464:21)
❌ _check should be called once in "divide"
AssertionError: expected _check to have been called exactly once, but it was called 0 times
at Context.<anonymous> (src/calculator.test.js:42:43)
at processImmediate (node:internal/timers:464:21)
i made changes according to instructions