Add timer origin to the history information#1627
Open
acroca wants to merge 5 commits into
Open
Conversation
Signed-off-by: Albert Callarisa <albert@diagrid.io>
There was a problem hiding this comment.
Pull request overview
Adds display of timer origin information in workflow history output (details + attrs) and validates it via unit and e2e tests.
Changes:
- Extend
pkg/workflowhistory formatting to surface timer origin (createTimer / externalEvent / activityRetry / childWorkflowRetry). - Add unit tests for origin formatting and details derivation.
- Add e2e coverage and supporting test workflows/activities for retry-origin timers; bump related Go module deps.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/standalone/workflow_test.go | Adds e2e assertions that history output includes timer origin in both text details and JSON attrs. |
| tests/apps/workflow/app.go | Registers new workflows/activities used to generate retry-origin timer events in e2e. |
| pkg/workflow/history.go | Adds origin decoding into history “Attrs” and “Details” output. |
| pkg/workflow/history_test.go | New unit tests for timer origin formatting and inclusion in derived details. |
| go.mod | Bumps durabletask-go + kit and adds new indirect deps. |
| go.sum | Updates sums for the module changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Member
Author
|
Waiting for #1629 to be merged |
Signed-off-by: Samantha Coyle <sam@diagrid.io> Signed-off-by: Albert Callarisa <albert@diagrid.io>
4 tasks
Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: Albert Callarisa <albert@diagrid.io>
| // WTimer calls ctx.CreateTimer which produces origin=createTimer. | ||
| _, err := cmdWorkflowRun(appID, "WTimer", "--instance-id=timer-origin-test") | ||
| require.NoError(t, err) | ||
|
|
cicoyle
requested changes
May 19, 2026
Contributor
cicoyle
left a comment
cicoyle
left a comment
There was a problem hiding this comment.
changes mostly lgtm but there are test failures still from this PR - please take a look and address it and copilots feedback:
time="2026-05-12T16:21:38.006246853Z" level=info msg="Workflow Actor 'child-retry-origin-test:0002': workflow completed with status 'ORCHESTRATION_STATUS_FAILED' workflowName 'FailingChildWorkflow'" app_id=test-workflow instance=runnervmeorf1 scope=dapr.runtime.actors.targets.orchestrator type=log ver=1.18.0-rc.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timers have
originnow. This PR displays the timer origin.