refactor: migrate macOS Objective-C bindings from objc/cocoa to objc2#320
Closed
Scott McMaster (scottmcmaster) wants to merge 2 commits into
Closed
refactor: migrate macOS Objective-C bindings from objc/cocoa to objc2#320Scott McMaster (scottmcmaster) wants to merge 2 commits into
objc/cocoa to objc2#320Scott McMaster (scottmcmaster) wants to merge 2 commits into
Conversation
Collaborator
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Scott McMaster (scottmcmaster)
requested review from
Copilot and
cooper (czxtm)
and removed request for
Copilot
Copilot started reviewing on behalf of
Scott McMaster (scottmcmaster)
June 5, 2026 01:29
View session
Scott McMaster (scottmcmaster)
changed the title
objc/cocoa to objc2
Contributor
📋 PR Overview
🔬 Coverage
|
Scott McMaster (scottmcmaster)
force-pushed
the
06-05-scott-update-objc2
branch
from
37c3ae9 to
6047342
Compare
Copilot started reviewing on behalf of
Scott McMaster (scottmcmaster)
June 5, 2026 02:24
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the macOS-specific Objective-C interop in the Tauri Rust backend from the deprecated objc/cocoa crates to the objc2 ecosystem to eliminate new deprecation warnings that are blocking builds on develop.
Changes:
- Replace
cocoa/objcusage withobjc2+objc2-foundationin native notification code. - Replace manual
msg_send!-based NSWindow manipulation with typedobjc2-app-kitAPIs for window behavior/diagnostics. - Update macOS-only Cargo dependencies and lockfile to drop
cocoa/objcand addobjc2crates.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.lock | Removes cocoa/objc-related packages and records new objc2* dependency graph. |
| apps/native/src-tauri/src/state/drift_notifications.rs | Refactors UserNotifications interop to use objc2/objc2-foundation and retained wrappers. |
| apps/native/src-tauri/src/peek.rs | Switches NSWindow configuration to typed objc2-app-kit APIs. |
| apps/native/src-tauri/src/main.rs | Switches NSWindow diagnostic reads to typed objc2-app-kit APIs. |
| apps/native/src-tauri/Cargo.toml | Replaces macOS target deps (cocoa/objc) with objc2, objc2-app-kit, and objc2-foundation. |
…aused release crashes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bunch of deprecation warnings that got introduced today on
developthat were blocking builds.Test Plan
Build and start the app.
Docs