Skip to content

Ensure settings passed to AVI are actually applied #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darnstrom merged 1 commit into from
Aug 11, 2026
Merged

Ensure settings passed to AVI are actually applied #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions interfaces/daqp-julia/src/api.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ function avi(H::Matrix{Float64},f::Vector{Float64},
A::Matrix{Float64},bupper::Vector{Float64},blower::Vector{Float64}=Float64[],sense::Vector{Cint}=Cint[];A_rowmaj=false,settings=nothing, primal_start::Vector{Cdouble}=Cdouble[],
dual_start::Vector{Cdouble}=Cdouble[])
d = DAQPBase.Model()
!isnothing(settings) && DAQPBase.settings(d,settings)
exitflag,setup_time = DAQPBase.setup(d,QPj(H,f,A,bupper,blower,sense;A_rowmaj,is_avi=true);
primal_start,dual_start,init_mask=DAQP_UPDATE_eliminate)
return DAQPBase.solve(d;setup_time);
Expand Down
6 changes: 6 additions & 0 deletions interfaces/daqp-julia/test/core_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,12 @@ end
@test norm(xref-x) < tol;
end

# Test avi interface by passing settings
xref,H,f,A,b = generate_test_avi(n,m)
s = settings(DAQPBase.Model(), Dict(:iter_limit => 1))
_,_,exitflag,_ = DAQPBase.avi(H,f,A,b; settings=s)
@test exitflag == DAQPBase.ITERLIMIT

# Test that update does not cause a segfault for AVIs
n = 10; m = 50
xref,H,f,A,b = generate_test_avi(n,m);
Expand Down
2 changes: 1 addition & 1 deletion interfaces/daqp-julia/test/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ function generate_test_avi(n,m)
M,N = rand(n,n),randn(n,n)
sym = M'*M
asym = N-N'
H = sym/norm(sym) + asym/(asym)
H = sym/norm(sym) + asym/norm(asym)

# f to satisfy stationarity
f = -H*x-A[AS,:]'*λ[AS]
Expand Down
Loading