fix(plugins): reload updated plugins via version-keyed cache paths#103
Merged
Conversation
Bump @data-fair/lib-node-registry to ^0.7.0, which extracts each plugin version into its own directory (<version>+<epoch>/<buildTuple>) behind a stable pointer file. An updated plugin now resolves to a fresh absolute path, so the long-lived API process reloads the whole module graph instead of serving stale code. The old `cacheBust` query-string only re-evaluated the entry module, leaving transitive imports (siblings + bundled deps) stale; drop it and the now-unused option from importPluginModule. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade
@data-fair/lib-node-registryto^0.7.0and remove the query-string cache-busting fromimportPluginModule.Why: 0.7.0 extracts each plugin version into its own directory, so an updated plugin resolves to a fresh module URL and Node's registry reloads the whole graph naturally — the manual
?imported=<timestamp>cache-bust in the API'sprepareflow is no longer needed.Regression risks:
prepareflow can run twice in one save (api/src/processings/router.ts:187); the second import now hits Node's module cache. Safe as long as the path is identical across both runs within a save, which it should be.