Fix motif collapse dropping activities on duplicate matches - #34
Open
matthewmoorcroft wants to merge 2 commits into
Open
Fix motif collapse dropping activities on duplicate matches#34matthewmoorcroft wants to merge 2 commits into
matthewmoorcroft wants to merge 2 commits into
Conversation
Rewrite internal package-proxy URLs (pypi-proxy.dev.databricks.com) to pypi.org / files.pythonhosted.org so public CI resolves deps. Same pinned versions and hashes; matches main. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28
What
When the same motif matched twice in one pipeline,
collapse_motifsdeduped bymotif_idandcontinue-skipped the second match — dropping its activities from the output and leaving danglingdepends_onedges → invalid dependency graph at deploy.Now each detected match is tracked by identity and gets a unique
task_keyper occurrence (motif_X,motif_X_2, …) via atask_key_suffix, recording every member'stask_key → motifmapping so_rewire_dependenciesstill redirects edges correctly.Scope
src/flowx/motifs/collapser.pyonly. Intra-pipeline bug — independent of the lineage epic (#23/#24).Testing
make testfull unit suite green;test_motifs.pypasses.This pull request and its description were written by Isaac.