Backfill task-value dependency edges so jobs are accepted at deploy - #35
Open
matthewmoorcroft wants to merge 2 commits into
Open
Backfill task-value dependency edges so jobs are accepted at deploy#35matthewmoorcroft wants to merge 2 commits into
matthewmoorcroft wants to merge 2 commits into
Conversation
Rewrite internal package-proxy URLs (pypi-proxy.dev.databricks.com) to pypi.org / files.pythonhosted.org so public CI resolves deps. Same pinned versions and hashes; matches main. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30
What
Databricks rejects a job whose task references
{{tasks.P.values.Y}}whenPis not a dependency of the referencing task (INVALID_PARAMETER_VALUE: Task 'P' must be a dependency of task 'T'). flowx rewrites ADF@variables()/@activity().outputinto such task-value refs (synthesised_init_<var>tasks and IfCondition/Switch/ForEach bridges) without always adding the matchingdepends_onedge.New
_backfill_task_value_dependenciesruns after_strip_dangling_task_value_refs: it scanscondition_task.{left,right}andnotebook_task.base_parametersfor{{tasks.P.values.*}}refs and appends{"task_key": P}to the consumer'sdepends_onwhenPexists in the job's task list and isn't already a direct dependency. Operates per job scope; recurses intofor_eachbodies against their own sibling set.Scope
src/flowx/bundler/dab_writer.pyonly (the task-value dependency backfill; the cross-bundle ref rewrite is a separate PR). Intra-job correctness — independent of the lineage epic (#23/#24).Testing
make testfull unit suite green (714 passed, 1 skipped);test_bundler.py+test_bundle_invariants.pypass.This pull request and its description were written by Isaac.