Skip to content

nextchanges: Auto-fix during validate_nextchanges - #6454

Open
janniklasrose wants to merge 3 commits into
janniklasrose/nextchanges-enforce-formatfrom
janniklasrose/nextchanges-autofix
Open

nextchanges: Auto-fix during validate_nextchanges#6454
janniklasrose wants to merge 3 commits into
janniklasrose/nextchanges-enforce-formatfrom
janniklasrose/nextchanges-autofix

Conversation

@janniklasrose

@janniklasrose janniklasrose commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Allow auto-fix of missing PR link in nextchanges fragments

Comment thread Taskfile.yml Outdated
full:
desc: More complete dev loop (full rather than incremental formatters and linters)
cmds:
- task: fix-changelog

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use fix- prefix with other linters -- most of them do modifications in place already. This is the default behaviour for a linter.

For the same reason, we dont add --fix flag to scripts, just modify it by default. CI is configured to catch diffs post-lint.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm used to linters having lint and lint --fix but aligning with convention here

@janniklasrose
janniklasrose marked this pull request as ready for review September 1, 2026 11:54
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

Based on git history, these people are best suited to review:

  • @denik -- recent work in tools/

Eligible reviewers: @andrewnester, @anton-107, @lennartkats-db, @pietern, @rclarey, @renaudhartert-db, @rugpanov, @shreyas-goenka, @simonfaltum

Suggestions based on git history. See OWNERS for ownership rules.

@janniklasrose janniklasrose changed the title Add --fix for nextchanges Auto-fix during validate_nextchanges Sep 1, 2026
@janniklasrose janniklasrose changed the title Auto-fix during validate_nextchanges nextchanges: Auto-fix during validate_nextchanges Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants