chore: upgrade Scala Native to 0.5.12#867
Draft
He-Pin wants to merge 1 commit into
Draft
Conversation
95b792a to
0a76b0c
Compare
9b6b86f to
619d008
Compare
Motivation: Adopt the latest Scala Native 0.5.x release so future native profiling and benchmarking use the current toolchain baseline. Modification: Bump the sjsonnet native cross module from Scala Native 0.5.11 to 0.5.12, use java.util.HexFormat for native hash rendering now that Scala Native provides it, and allow fork PR CI to use Maven Central when no Databricks JFrog token is available. Result: JVM tests, native tests, native linking, formatting, and the full test suite pass locally. The kube-prometheus native output remains byte-identical against a 0.5.11 baseline. References: https://github.com/scala-native/scala-native/releases/tag/v0.5.12
619d008 to
68bde92
Compare
This was referenced May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Upgrade the Scala Native baseline to 0.5.12 so follow-up native profiling, async-profiler work, and compatibility work use the latest released 0.5.x toolchain.
Key Design Decision:
Keep this PR focused on the toolchain migration and API cleanup enabled by that migration. The root sbt files were checked:
build.sbtis JVM-only for this repository andproject/plugins.sbtonly adds JMH, so there is no Scala Native sbt plugin version to update here.Modification:
scalaNativeVersionfrom0.5.11to0.5.12inbuild.mill.java.util.HexFormatin the Scala Native platform hash implementation now that Scala Native 0.5.12 provides it.Benchmark Results:
Not included for this dependency upgrade. This PR establishes the 0.5.12 baseline; follow-up optimization PRs should benchmark their own performance deltas on top of this version.
Analysis:
Scala Native 0.5.12 includes release GC reliability fixes, codegen/toolchain improvements, and Java 17
HexFormatsupport. TheHexFormatchange makes the native hash path match the JVM implementation more closely and reduces platform-specific code without changing Jsonnet semantics. The CI repository fallback keeps authenticated Databricks JFrog usage for trusted runs. For fork PRs without OIDC credentials, it uses the Google Maven Central mirror fallback and forces the Mill JVM launcher (MILL_VERSION=<version>-jvm) because the native Mill launcher failed Java TLS handshakes to HTTPS Maven Central mirrors before reaching project dependency resolution. In dummy-token mode it also injects--no-server.References:
Result:
./mill 'sjsonnet.jvm[3.3.7].test'passed../mill 'sjsonnet.native[3.3.7].nativeLink'passed../mill __.reformat && ./mill --no-server --ticker false --color false -j 1 __.testpassed 444/444 before the HexFormat cleanup../mill __.reformat && ./mill 'sjsonnet.native[3.3.7].test'passed 457/457 after the HexFormat cleanup.bash -n .github/scripts/fix-build-config.shpassed.local+google-maven-central: https://maven-central.storage-download.googleapis.com/maven2/, exportsCOURSIER_REPOSITORIES=https://maven-central.storage-download.googleapis.com/maven2/, rewrites the Mill launcher URL to the same mirror, setsMILL_VERSION=1.1.5-jvm, injects--no-server, and appends Java TLS/IPv4 options for public mirror access.