fix: use empty defaults for OAuth-mode API key headers#17
Open
nicoyoung wants to merge 1 commit into
Open
Conversation
jfree
approved these changes
Jun 11, 2026
2146740 to
b495955
Compare
Author
|
Friendly ping @datadog-labs/mcp-server / @m-paternostro — this fixes the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The MCP server config declares the
DD_API_KEYandDD_APPLICATION_KEYheaders as${DD_API_KEY}/${DD_APPLICATION_KEY}with no default. The plugin authenticates via OAuth by default, so these are normally unset, and Claude Code's static MCP-config validator treats a${VAR}reference without a default as a required variable. On a default (OAuth) install it therefore reports the server as invalid:This surfaces in
/doctorfor every OAuth user even though the server connects and works. This PR gives the two headers empty defaults (${DD_API_KEY:-}/${DD_APPLICATION_KEY:-}), matching how${DD_MCP_TOOLSETS:-}is already handled in the same file. Behavior is unchanged: when the variables are set (advanced API-key usage) their values are used; when unset (OAuth) they resolve to empty strings instead of being flagged as missing.Checklist
Closes #18