Fix LLM model tenant authorization - #824
Merged
Merged
Conversation
yaojin3616
marked this pull request as ready for review
August 7, 2026 07:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Organization admins could submit another tenant's model UUID to the update or default-selection endpoints. Those handlers loaded the model by ID without a tenant predicate, allowing changes to the other tenant's Base URL and API key.
Impact
An organization admin can now manage only models in their own tenant. Platform administrators retain cross-tenant management access.
Validation
PYTHONPATH=. uv run pytest tests/test_llm_model_tenant_scope.py tests/test_llm_tool_capability_probe.py tests/test_model_logical_delete.pyPYTHONPATH=. uv run ruff check tests/test_llm_model_tenant_scope.py