Skip to content

Restrict global system settings to platform admins - #825

Closed
yaojin3616 wants to merge 1 commit into
mainfrom
agent/debugger/1d572dfc
Closed

Restrict global system settings to platform admins#825
yaojin3616 wants to merge 1 commit into
mainfrom
agent/debugger/1d572dfc

Conversation

@yaojin3616

Copy link
Copy Markdown
Collaborator

Summary

  • restrict global system-setting reads and writes to platform administrators
  • retain the dedicated public notification-bar endpoint as the only unauthenticated settings read
  • add regression coverage for member and organization-admin denial cases

Root cause

The generic system-settings read route required only authentication, while the write route accepted organization administrators. Both routes provide access to platform-wide values, including SMTP and Jina credentials.

Validation

  • PYTHONPATH=. uv run pytest tests/test_system_settings_api.py
  • PYTHONPATH=. uv run ruff check tests/test_system_settings_api.py

Closes #152

@yaojin3616 yaojin3616 closed this Aug 5, 2026
@yaojin3616
yaojin3616 deleted the agent/debugger/1d572dfc branch August 5, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant