Fix Vercel async deployment wait settlement - #827
Draft
Y1fe1Zh0u wants to merge 1 commit into
Draft
Conversation
Vercel deployment acceptance is not terminal success. Declare non-terminal deployments as durable async operations, poll the exact deployment ID through the existing Runtime, and settle only on authoritative terminal provider states. The accompanying Spec Kit artifacts preserve the decision and regression contract. Constraint: Reuse the existing Runtime scheduler and settlement path without generic Runtime changes Rejected: Treat accepted or BUILDING deployments as success | loses the authoritative provider result Rejected: Poll deployment lists | cannot prove which deployment owns the operation Confidence: high Scope-risk: narrow Reversibility: clean Directive: Do not reclassify Vercel acceptance as terminal success or replay launch writes from poll continuations Tested: 102 scoped Vercel and Runtime tests; 172 deploy and Tool contract regression tests; scoped Ruff critical rules Not-tested: Live Vercel deployment and long-duration retry termination policy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
INITIALIZING,QUEUED, andBUILDINGdeployment states as durable pending operations.READY,ERROR, orCANCELED.Why
The deployment create response proves that Vercel accepted the deployment, but it does not prove that the deployment completed. The previous implementation classified an accepted
BUILDINGdeployment as successful, so Runtime had no authoritative pending operation to poll and settle. This could leave the Run waiting without consuming the final provider state.Impact
Users now receive the authoritative result of the deployment they started. Non-terminal deployments remain waiting under the existing Runtime scheduler, successful deployments resume on
READY, and terminal failures resume through existing failure handling. The generic Runtime and other Tool contracts are unchanged.Validation
Out of scope