fix(sso): honour sso_custom_domain_redirect_enabled in /sso/config - #849
Open
libingtong wants to merge 1 commit into
Open
fix(sso): honour sso_custom_domain_redirect_enabled in /sso/config#849libingtong wants to merge 1 commit into
libingtong wants to merge 1 commit into
Conversation
get_sso_config() calls get_tenant_sso_base_url() without passing
sso_redirect_enabled, so the parameter defaults to True and the
`sso_custom_domain_redirect_enabled` platform setting is ignored on this path.
The method's own docstring states the caller should pre-resolve the flag via
system_setting_dao.is_sso_custom_domain_redirect_enabled(), and app/api/auth.py
already does exactly that — /sso/config is inconsistent with it.
Impact for single-domain deployments (one host serving the platform, admin has
turned the setting off): get_tenant_sso_base_url() falls through to the tenant
subdomain branch and rewrites `app.example.com` into
`{tenant.slug}.example.com`, so every SSO button on the login page points at a
host that does not exist. Turning the setting off has no effect because this
call site never reads it.
Resolve the flag the same way auth.py does and pass it through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_sso_config()callsget_tenant_sso_base_url()without passingsso_redirect_enabled, so the parameter defaults toTrueand thesso_custom_domain_redirect_enabledplatform setting is ignored on this path.The method's own docstring states the caller should pre-resolve the flag via
system_setting_dao.is_sso_custom_domain_redirect_enabled(), andapp/api/auth.pyalready does exactly that —/sso/configis inconsistent with it.Impact
For single-domain deployments (one host serving the platform, admin has turned the setting off),
get_tenant_sso_base_url()falls through to the tenant-subdomain branch and rewritesapp.example.cominto{tenant.slug}.example.com. Every SSO button on the login page then points at a host that does not exist, and turning the setting off has no effect because this call site never reads it.This PR
Resolves the flag the same way
auth.pydoes and passes it through. One call site, no behaviour change for deployments that leave the setting enabled.