Skip to content

fix(identity): normalize blank email/phone to NULL before persisting #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
libingtong wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

fix(identity): normalize blank email/phone to NULL before persisting #850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions backend/app/services/registration_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,15 @@ async def find_or_create_identity(
"""
identity: Identity | None = None

# identities.email and .phone are both unique and nullable. Postgres allows
# many NULLs in a unique index but only a single empty string, so persisting
# "" makes the *second* contact-less identity fail with
# UniqueViolationError on ix_identities_email / ix_identities_phone.
# SSO providers pass ExternalUserInfo defaults ("") when the upstream
# directory exposes no address, so normalize before both lookup and insert.
email = (email or "").strip() or None
phone = (phone or "").strip() or None

# Match by email (primary ownership claim)
if email:
identity = await identity_dao.get_by_email(email)
Expand Down