feat(add-data): Add modal to import data via file upload#189
Open
david-bretaud-dev wants to merge 3 commits into
Open
Conversation
david-bretaud-dev
force-pushed
the
david-bretaud-dev/feat-add-modal-to-import-new-data
branch
from
July 19, 2026 08:23
beffea5 to
04316e3
Compare
Comment on lines
+23
to
33
| layerOptions: [ | ||
| { | ||
| translation: t("filters.categories.actions.forestInventary"), | ||
| value: LAYERS.INVENTARY, | ||
| }, | ||
| { | ||
| translation: t("filters.categories.actions.socioEco"), | ||
| value: LAYERS.ENQUETE, | ||
| }, | ||
| ], | ||
| logoSrc: "/logo_all4trees.png", |
Collaborator
Author
There was a problem hiding this comment.
NB: this is a tenant config that drilled to the Add data dialog in the header.. I have plan to move away from props drilling and provide a new react context for these tenant configurations that are used in agnostic pages
cf #196
david-bretaud-dev
force-pushed
the
david-bretaud-dev/feat-add-modal-to-import-new-data
branch
from
July 19, 2026 08:33
04316e3 to
54560ef
Compare
david-bretaud-dev
changed the base branch from
main
to
david-bretaud-dev/refactor-remove-spacing-tokens
July 19, 2026 08:33
david-bretaud-dev
force-pushed
the
david-bretaud-dev/refactor-remove-spacing-tokens
branch
from
July 19, 2026 08:35
cf98511 to
9976ad4
Compare
david-bretaud-dev
force-pushed
the
david-bretaud-dev/feat-add-modal-to-import-new-data
branch
from
July 19, 2026 08:35
54560ef to
db3ec55
Compare
arnaudfnr
reviewed
Jul 19, 2026
| hasDashboard: true, | ||
| layerOptions: [ | ||
| { | ||
| translation: t("filters.categories.actions.forestInventary"), |
Collaborator
There was a problem hiding this comment.
To be updated to forestInventOry with an 'o', also the layer name will have to be updated after #182 merge
| { | ||
| translation: t("filters.categories.actions.socioEco"), | ||
| value: LAYERS.ENQUETE, | ||
| }, |
Collaborator
There was a problem hiding this comment.
New layer inventory_bio will need to be added after #182 merge
| // Accepted upload extensions per kind (coordo's file / kobotoolbox loaders). | ||
| // Form data is the multi-sheet KoboToolbox answers workbook (.xlsx). | ||
| export const ACCEPTED_EXTENSIONS_BY_KIND = { | ||
| [RESOURCE_KINDS.ExternalData]: ".csv,.xls,.xlsx", |
Collaborator
There was a problem hiding this comment.
| // Form data is the multi-sheet KoboToolbox answers workbook (.xlsx). | ||
| export const ACCEPTED_EXTENSIONS_BY_KIND = { | ||
| [RESOURCE_KINDS.ExternalData]: ".csv,.xls,.xlsx", | ||
| [RESOURCE_KINDS.FormData]: ".xlsx", |
Collaborator
There was a problem hiding this comment.
Same here, csv are supported too : https://github.com/dataforgoodfr/Coordonnees/blob/c6a65de3db142e9b1a7505224cce794c4d1ef7a2/coordo-py/coordo/loaders/kobotoolbox_loader.py#L216
Suggested change
| [RESOURCE_KINDS.FormData]: ".xlsx", | |
| [RESOURCE_KINDS.FormData]: [".csv", ".xlsx"], |
| "field": { | ||
| "file": "File to upload", | ||
| "form": "Layer / Form to update", | ||
| "formPlaceholder": "Select a layer", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "formPlaceholder": "Select a layer", | |
| "formPlaceholder": "Select a data source", |
| "pending": "Envoi en cours...", | ||
| "submit": "Ajouter les données" | ||
| }, | ||
| "description": "Importez un fichier pour ajouter des données à une couche de la carte.", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "description": "Importez un fichier pour ajouter des données à une couche de la carte.", | |
| "description": "Importez un fichier pour ajouter des données à la carte.", |
| "error": { | ||
| "generic": "Upload failed. Please try again.", | ||
| "missingFile": "Please choose a file to upload.", | ||
| "missingForm": "Please select a layer to update." |
Collaborator
There was a problem hiding this comment.
Suggested change
| "missingForm": "Please select a layer to update." | |
| "missingForm": "Please select a data source to update." |
| }, | ||
| "field": { | ||
| "file": "File to upload", | ||
| "form": "Layer / Form to update", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "form": "Layer / Form to update", | |
| "form": "Data source to update", |
| "pending": "Uploading...", | ||
| "submit": "Add data" | ||
| }, | ||
| "description": "Upload a file to add data to a map layer.", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "description": "Upload a file to add data to a map layer.", | |
| "description": "Upload a file to add data to the map.", |
| }, | ||
| "field": { | ||
| "file": "Fichier à importer", | ||
| "form": "Couche / Formulaire à mettre à jour", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "form": "Couche / Formulaire à mettre à jour", | |
| "form": "Source de données à mettre à jour", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights
Demos
UI only
demo-upload-file-data-ui.mp4
Full flow
Waiting for backend