Skip to content

Add sharing API and UI for collections#1564

Merged
ml-evs merged 4 commits intomainfrom
bc/ui-sharing-col
May 7, 2026
Merged

Add sharing API and UI for collections#1564
ml-evs merged 4 commits intomainfrom
bc/ui-sharing-col

Conversation

@BenjaminCharmes
Copy link
Copy Markdown
Contributor

@BenjaminCharmes BenjaminCharmes commented Jan 27, 2026

Closes #1524

Changes:

  • Add permission editors to collection edit page
  • Add group/creator selectors to collection creation modal
  • Add PATCH /collections/<id>/permissions endpoint
  • Include groups lookup in collection GET requests

Collections now support the same permission system as items, with groups providing read-only access and creators having read-write access.

When a user has access to a collection as a creator or via group membership, they also get read access to the items within.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 83.72093% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.88%. Comparing base (ce4f17c) to head (2f82e1d).

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/routes/v0_1/collections.py 82.19% 13 Missing ⚠️
pydatalab/src/pydatalab/permissions.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1564      +/-   ##
==========================================
+ Coverage   78.82%   78.88%   +0.05%     
==========================================
  Files          81       81              
  Lines        7038     7118      +80     
==========================================
+ Hits         5548     5615      +67     
- Misses       1490     1503      +13     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/routes/v0_1/items.py 83.01% <100.00%> (ø)
pydatalab/src/pydatalab/permissions.py 89.47% <91.66%> (+0.15%) ⬆️
pydatalab/src/pydatalab/routes/v0_1/collections.py 78.53% <82.19%> (+1.87%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link
Copy Markdown

cypress Bot commented Jan 27, 2026

datalab    Run #4862

Run Properties:  status check passed Passed #4862  •  git commit 9db6c765e4 ℹ️: Merge 2f82e1d6651e979b7f6b7077345f0c6f32367297 into ce4f17ca0b26aa74d6566c001b4a...
Project datalab
Branch Review bc/ui-sharing-col
Run status status check passed Passed #4862
Run duration 09m 44s
Commit git commit 9db6c765e4 ℹ️: Merge 2f82e1d6651e979b7f6b7077345f0c6f32367297 into ce4f17ca0b26aa74d6566c001b4a...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

@BenjaminCharmes BenjaminCharmes force-pushed the bc/ui-sharing-col branch 2 times, most recently from c3a5da2 to 9da99c9 Compare January 27, 2026 16:49
@ml-evs ml-evs force-pushed the bc/ui-sharing-col branch 3 times, most recently from 5f419b8 to 65ad45a Compare February 19, 2026 14:56
@ml-evs ml-evs force-pushed the bc/ui-sharing-col branch from 65ad45a to fa6a221 Compare April 29, 2026 21:38
@ml-evs ml-evs marked this pull request as ready for review April 29, 2026 21:38
@ml-evs ml-evs self-requested a review April 29, 2026 21:38
@ml-evs ml-evs added this to the v0.7.x milestone Apr 29, 2026
manual pre-commit

Fix mongodump installation issue in server container (#1561)

manual pre-commit

Manual apply prettier formatting

manual fix pre-commit
@ml-evs ml-evs force-pushed the bc/ui-sharing-col branch from fa6a221 to 52e281d Compare April 30, 2026 13:25
@ml-evs ml-evs force-pushed the bc/ui-sharing-col branch 2 times, most recently from 15f5da9 to 2f82e1d Compare May 3, 2026 09:17
@ml-evs ml-evs changed the title Add sharing UI for collections Add sharing API and UI for collections May 7, 2026
@ml-evs ml-evs merged commit 930fa77 into main May 7, 2026
16 checks passed
@ml-evs ml-evs deleted the bc/ui-sharing-col branch May 7, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI for sharing collections

2 participants