Use SPA navigation between table and edit pages and lazy-load schemas#1687
Merged
Use SPA navigation between table and edit pages and lazy-load schemas#1687
Conversation
ml-evs
added
webapp
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1687 +/- ##
=======================================
Coverage 78.82% 78.82%
=======================================
Files 81 81
Lines 7038 7038
=======================================
Hits 5548 5548
Misses 1490 1490 🚀 New features to boost your workflow:
|
datalab
 |
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/lazy-load-schemas
|
| Run status |
|
| Run duration | 09m 20s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
0
|
 |
0
|
 |
478
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
force-pushed
the
ml-evs/lazy-load-schemas
branch
2 times, most recently
from
79bece3 to
6b61a3d
Compare
ml-evs
force-pushed
the
ml-evs/lazy-load-schemas
branch
from
6b61a3d to
7fe6fe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reintroduces SPA navigation between sample pages without requiring full page reload. It also forces schema load when loading the app, rather than on every item page. Finally it fixes an auth bug where the app would not correctly redirect when logging in via an email magic link (closes #1640).